Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support resource deletion with LIST(SLEEP) #313

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support resource deletion with LIST(SLEEP) #313

wants to merge 1 commit into from

Conversation

hwan0079
Copy link

This is related to issue - #311.
There is bug when the resource is deleted with method - SLEEP.

ERROR:

Traceback (most recent call last):
  File "/app/resources.py", line 300, in _update_file
    return remove_file(dest_folder, filename)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/app/helpers.py", line 103, in remove_file
    complete_file = os.path.join(folder, filename)
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen posixpath>", line 76, in join
TypeError: expected str, bytes or os.PathLike object, not NoneType

@ChristianGeie ChristianGeie added bug Something isn't working python Pull requests that update Python code labels Nov 29, 2023
@ChristianGeie
Copy link
Collaborator

Thx for the PR, LGTM so far. But I would like to do some more test...

@ns-phegde
Copy link

Thx for the PR, LGTM so far. But I would like to do some more test...

@ChristianGeie Would you know when this feature will be supported? Thanks.

@ChristianGeie
Copy link
Collaborator

I thought about the SLEEP for a long time same for WATCH. Currently #326 looks good to me, so I would prefer that.
@ns-phegde After implementing and some more tests I'll jump into your request.

@ns-phegde
Copy link

@ChristianGeie @jekkel Hope guys are well.
Did you guys get some time discuss adding more tests so we can get this PR merged?

@ChristianGeie
Copy link
Collaborator

I have a lot to do at the moment and my reviewers are not available. I am grateful for any help.

@tomrk-esteam8
Copy link
Collaborator

please add some tests :-)

@github-actions github-actions bot added the stale close issues and PRs after 60 days of inactivity label Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working python Pull requests that update Python code stale close issues and PRs after 60 days of inactivity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hwan0079 @ChristianGeie @ns-phegde @tomrk-esteam8 @Harry7983